-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rando] Add Mix and Decouple support to Boss Entrances #3261
[Rando] Add Mix and Decouple support to Boss Entrances #3261
Conversation
To go with you should be able to select vanilla dungeon rewards so bosses keep their original ones This would be useful for hints so you know who the bosses are based on the reward hint. So Goron Ruby being at graveyard will tell you it's KD there. |
A "vanilla" option for "Shuffle Dungeon Rewards" would be out of scope for this PR and should be handled on its own, but thanks for the suggestion! |
60583c2
to
bf7be66
Compare
I think instead of that, it should just be gossip hints (Dodongo's Cavern leads into Shadow Temple) |
N64 rando has the compass tell you where the dungeon reward is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After playing with this for a while, I haven't found any issues.
// RANDOTODO: Only show blue warps if bluewarp shuffle is on | ||
if (original->metaTag.ends_with("bw") || override->metaTag.ends_with("bw")) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope for this PR (and i don't know if this is handled differently in rando v3), but this feels like a perfect example of the fragility of string based metatags (ENTR_LAKE_HYLIA_9
wouldn't work if the tag was entered as "bw,lh"
instead of "lh,bw"
)
depending on how many tags we have it might make sense to use bitpacking instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have fun with these conflicts on v3 🙈
This PR adds support for mixing boss entrances into the mixed pool as well as decoupling boss room entrances.
Mixing boss rooms is only possible if boss entrances are set to "Full". Decouple logic on it's own will only account for being able to exit Ghoma's and King Dodongo's room.
Dungeon chains is effectively achieved by at least shuffling dungeon and boss entrances, then mixing only dungeons and bosses together.
Behind the scenes, blue warp handling was refactored to add blue warps into logic and handle assigning the right entrance during generation. These entrances are not unique overrides, instead of being tacked on as a property of other entrances. This simplifies the blue warp overrides on the game side and allows us to preserve the original warp entrance values, as well as opens the floor for a Blue Warp shuffle setting (in a future PR 😉). For now these blue warp entrances are hidden in the entrance tracker, but will be available when the blue warp setting is added.
- [ ] Consider additional option to make it so you can exit adult boss rooms?N64 rando does not do this. I'm considering this out of scope and should be it's own feature due to how involved the logic is and changing how boss doors work entirely.Build Artifacts