[Tweak] Improve Free Camera clear action #3225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intention was that pressing Z-target was how to reset the free camera and go back to the normal camera. This was done by clearing free camera when the "parallel cam" was active (the standard Z-Target cam). The problem is this camera is only used when Link is idle. Free camera could not be reset when actively climbing or riding Epona.
This PR is to improve how free camera is cleared and handle more situations that cause jarring camera movement. The logic for determining this is moved to the
Camera_ChangeModeflow and using the mode directly to decide the action. Specifically the following situations will now clear the free cam.Fixes #790 and most likely is the "real" fix for #863
Build Artifacts