Issue 651 - Clarify optional nature of row_id in active_cell (plotly#724

)
HammadTheOne · Apr 15, 2020 · 8dd5c9c · 8dd5c9c
1 parent 662835b
commit 8dd5c9c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/dash-table/CHANGELOG.md b/packages/dash-table/CHANGELOG.md
@@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Fixed
 - [#722](https://github.com/plotly/dash-table/pull/722) Fix a bug where row height is misaligned when using fixed_columns and/or fixed_rows
 - [#728](https://github.com/plotly/dash-table/pull/728) Fix copy/paste on readonly cells
+- [#724](https://github.com/plotly/dash-table/pull/724) Fix `active_cell` docstring: clarify optional nature of the `row_id` nested prop
 
 ## [4.6.2] - 2020-04-01
 ### Changed

diff --git a/packages/dash-table/src/dash-table/dash/DataTable.js b/packages/dash-table/src/dash-table/dash/DataTable.js
@@ -110,7 +110,8 @@ export const defaultProps = {
 
 export const propTypes = {
     /**
-     * The row and column indices and IDs of the currently active cell.
+     * The row and column indices and IDs of the currently active cell. 
+     * `row_id` is only returned if the data rows have an `id` key.
      */
     active_cell: PropTypes.exact({
         row: PropTypes.number,
@@ -1299,4 +1300,4 @@ DataTable.persistenceTransforms = {
 };
 
 DataTable.defaultProps = defaultProps;
-DataTable.propTypes = propTypes;
+DataTable.propTypes = propTypes;