Issue 703 - Rename async modules (plotly#704)

HammadTheOne · Feb 27, 2020 · 6852769 · 6852769
1 parent cd11476
commit 6852769
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 10 deletions.
diff --git a/packages/dash-table/.circleci/config.yml b/packages/dash-table/.circleci/config.yml
@@ -3,7 +3,7 @@ version: 2
 jobs:
     "server-test":
         docker:
-            - image: circleci/python:3.6-node-browsers
+            - image: circleci/python:3.6.9-node-browsers
             - image: cypress/base:10
 
         steps:
@@ -40,7 +40,9 @@ jobs:
                     . venv/bin/activate
                     npm run private::build:js-test
                     npm run private::build:py
-                    pip install -e .
+                    python setup.py sdist
+                    cd dist
+                    find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
 
             - run:
                 name: Run tests
@@ -225,7 +227,9 @@ jobs:
                 command: |
                     . venv/bin/activate
                     npm run build
-                    pip install -e .
+                    python setup.py sdist
+                    cd dist
+                    find . -name "*.gz" | xargs pip install --no-cache-dir --ignore-installed && cd ..
 
             - run:
                 name: ⚙️ run integration test

diff --git a/packages/dash-table/.config/webpack/base.js b/packages/dash-table/.config/webpack/base.js
@@ -96,7 +96,11 @@ module.exports = (options = {}) => {
                 name: true,
                 cacheGroups: {
                     async: {
-
+                        chunks: 'async',
+                        minSize: 0,
+                        name(module, chunks, cacheGroupKey) {
+                            return `${cacheGroupKey}-${chunks[0].name}`;
+                        }
                     }
                 }
             }

diff --git a/packages/dash-table/CHANGELOG.md b/packages/dash-table/CHANGELOG.md
@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+### Changed
+- [#704](https://github.com/plotly/dash-table/pull/704) Renamed async modules with hyphen `-` instead of tilde `~`
+
 ## [4.6.0] - 2020-01-14
 ### Added
 - [#606](https://github.com/plotly/dash-table/pull/606) Add markdown support for table cells. Cells will be rendered as markdown if the column `presentation` is specified as `markdown`.

diff --git a/packages/dash-table/MANIFEST.in b/packages/dash-table/MANIFEST.in
@@ -1,7 +1,7 @@
 include dash_table/bundle.js
 include dash_table/bundle.js.map
-include dash_table/async~*.js
-include dash_table/async~*.js.map
+include dash_table/async-*.js
+include dash_table/async-*.js.map
 include dash_table/metadata.json
 include dash_table/package-info.json
 include LICENSE

diff --git a/packages/dash-table/dash_table_base/__init__.py b/packages/dash-table/dash_table_base/__init__.py
@@ -37,20 +37,20 @@
 _js_dist = []
 
 _js_dist.extend([{
-    'relative_package_path': 'async~{}.js'.format(async_resource),
+    'relative_package_path': 'async-{}.js'.format(async_resource),
     'external_url': (
         'https://unpkg.com/dash-table@{}'
-        '/dash_table/async~{}.js'
+        '/dash_table/async-{}.js'
     ).format(__version__, async_resource),
     'namespace': package_name,
     'async': True
 } for async_resource in async_resources])
 
 _js_dist.extend([{
-    'relative_package_path': 'async~{}.js.map'.format(async_resource),
+    'relative_package_path': 'async-{}.js.map'.format(async_resource),
     'external_url': (
         'https://unpkg.com/dash-table@{}'
-        '/dash_table/async~{}.js.map'
+        '/dash_table/async-{}.js.map'
     ).format(__version__, async_resource),
     'namespace': package_name,
     'dynamic': True