-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SSLContext customizable #360
Conversation
It seems like the changes are working fine, below is the output of the ssl handshake and the sslfactory configuration:
What do you think @woj-tek ? And coming back to your earlier concern. All of the properties are consistent: import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLSocket;
import java.io.IOException;
import java.util.Arrays;
public class App {
public static void main(String[] args) throws IOException {
SSLFactory sslFactory = SSLFactory.builder()
.withDefaultTrustMaterial()
.withProtocols("TLSv1.2")
.withNeedClientAuthentication()
.withCiphers("TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384")
.build();
System.out.println("SSLFactory");
System.out.println(sslFactory.getProtocols());
System.out.println("SSLContext");
System.out.println(Arrays.toString(sslFactory.getSslContext().getSupportedSSLParameters().getProtocols()));
System.out.println(Arrays.toString(sslFactory.getSslContext().getDefaultSSLParameters().getProtocols()));
System.out.println("SSLSocket");
SSLSocket socket = (SSLSocket) sslFactory.getSslSocketFactory().createSocket();
System.out.println(Arrays.toString(socket.getSupportedProtocols()));
System.out.println(Arrays.toString(socket.getEnabledProtocols()));
System.out.println(Arrays.toString(socket.getSupportedCipherSuites()));
System.out.println(Arrays.toString(socket.getEnabledCipherSuites()));
System.out.println(socket.getNeedClientAuth());
System.out.println(socket.getWantClientAuth());
System.out.println("SSLEngine");
SSLEngine sslEngine = sslFactory.getSSLEngine();
System.out.println(Arrays.toString(sslEngine.getSupportedProtocols()));
System.out.println(Arrays.toString(sslEngine.getEnabledProtocols()));
System.out.println(Arrays.toString(sslEngine.getSupportedCipherSuites()));
System.out.println(Arrays.toString(sslEngine.getEnabledCipherSuites()));
System.out.println(sslEngine.getNeedClientAuth());
System.out.println(sslEngine.getWantClientAuth());
}
}
|
Kudos, SonarCloud Quality Gate passed! |
Just tested it and it works as expected! 👍 |
No description provided.