-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.2 #313
Release v1.2 #313
Conversation
resolved deprecated errors related to set_ditgrid or Qr_layer_HAPI
…x_enable_x64' is True in contrast to when it is False.
Fixing Minor bugs
Refactoring 1
codeclimate budge and refactoring
Refactoring 3
@HajimeKawahara @astrostevanus Sorry, I mistakenly directly pushed to the release branch, but the commit 17ddb2a fixes the bug for nus grid, which is the cause of the error @astrostevanus found. I forgot that nus grid should always be increasing order when I fixed the grid setting bug (#319). I have confirmed that Forward_modeling_using_DIT.ipynb now works. |
I just thought that it would be better to explicitly write down somewhere that both wavenumber and wavelength grids, outputs of wavenumber_grid, are increasing orders, so instead of wav[0], wav[-1] corresponds to the wavelength of nus[0]. Also, cross sections and spectra are both calculated for that increasing-wavenumber grid. This is because I sometimes get confused. Sorry, if I just do not notice that they are already written somewhere. What would you think? |
@ykawashima Thanks! Yes I agree. I also always get confused. |
Note that the docs for the current release version is here |
Do you need more time @erwanp ? or maybe we can postpone it until v1.3. |
@HajimeKawahara I think the Register lines are the culprit : in
The only problem is it takes me time to set up a proper environment to test it in conditions similar to yours. @astrostevanus could you try with commenting the lines mentionned above ? You want to make sure that :
|
@erwanp Thanks a lot! in my side, it worked. Can you check the latest version @astrostevanus just in case? |
Hi @erwanp and @HajimeKawahara san, I will check it tomorrow night if you don't mind. I am on my annual leave today and tomorrow, so I don't have any access to my computer 😅. |
Hi @erwanp and @HajimeKawahara san, I have just checked it and it works well! |
Perfect thank you for trying |
Thanks a lot! |
Release branch for v1.2.
I will merge this branch to
master
and release v1.2 in November 21st unless any serious issues are found.Comments and reviews welcome for anyone!