Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.2 #313

Merged
merged 543 commits into from
Dec 7, 2022
Merged

Release v1.2 #313

merged 543 commits into from
Dec 7, 2022

Conversation

HajimeKawahara
Copy link
Owner

Release branch for v1.2.
I will merge this branch to master and release v1.2 in November 21st unless any serious issues are found.
Comments and reviews welcome for anyone!

  • Tutorials: I will reorganize them as possible.

chonma0ctopus and others added 30 commits August 25, 2022 13:40
resolved deprecated errors related to set_ditgrid or Qr_layer_HAPI
…x_enable_x64' is True in contrast to when it is False.
codeclimate budge and refactoring
@ykawashima
Copy link
Collaborator

@HajimeKawahara @astrostevanus Sorry, I mistakenly directly pushed to the release branch, but the commit 17ddb2a fixes the bug for nus grid, which is the cause of the error @astrostevanus found.

I forgot that nus grid should always be increasing order when I fixed the grid setting bug (#319).

I have confirmed that Forward_modeling_using_DIT.ipynb now works.

@ykawashima
Copy link
Collaborator

I just thought that it would be better to explicitly write down somewhere that both wavenumber and wavelength grids, outputs of wavenumber_grid, are increasing orders, so instead of wav[0], wav[-1] corresponds to the wavelength of nus[0]. Also, cross sections and spectra are both calculated for that increasing-wavenumber grid. This is because I sometimes get confused. Sorry, if I just do not notice that they are already written somewhere. What would you think?

@HajimeKawahara
Copy link
Owner Author

@ykawashima Thanks! Yes I agree. I also always get confused.

@HajimeKawahara
Copy link
Owner Author

Note that the docs for the current release version is here

@HajimeKawahara
Copy link
Owner Author

Do you need more time @erwanp ? or maybe we can postpone it until v1.3.

@erwanp
Copy link
Collaborator

erwanp commented Dec 5, 2022

@HajimeKawahara I think the Register lines are the culprit : in MdbHitran and in MdbHitemp they should be commented.

  • ExoJax philosophy is to compare paths given by users to the files on disk; if they aren't here files are downloaded.
  • Radis philosophy is to work with database names that are registered in radis.json
    Both have pros & cons; but in Exojax there shouldn't be any registration.

The only problem is it takes me time to set up a proper environment to test it in conditions similar to yours. @astrostevanus could you try with commenting the lines mentionned above ? You want to make sure that :

  • the error is not raised anymore
  • that HITRAN is not re-downloaded if it exists already

@HajimeKawahara
Copy link
Owner Author

@erwanp Thanks a lot! in my side, it worked. Can you check the latest version @astrostevanus just in case?

@astrostevanus
Copy link
Collaborator

Hi @erwanp and @HajimeKawahara san, I will check it tomorrow night if you don't mind. I am on my annual leave today and tomorrow, so I don't have any access to my computer 😅.

@astrostevanus
Copy link
Collaborator

Hi @erwanp and @HajimeKawahara san, I have just checked it and it works well!

@erwanp
Copy link
Collaborator

erwanp commented Dec 6, 2022

Perfect thank you for trying

@HajimeKawahara
Copy link
Owner Author

Thanks a lot!

@HajimeKawahara HajimeKawahara merged commit c6fbc2e into master Dec 7, 2022
@HajimeKawahara HajimeKawahara deleted the release branch December 8, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants