[core] WSASend overlapped #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
ethouris
reviewed
Nov 25, 2019
| // Wait for 20 ms | ||
| int rc = WSAWaitForMultipleEvents(1, &m_SendOverlapped.hEvent, TRUE, 50, TRUE); | ||
|
|
||
| if (rc == WSA_WAIT_FAILED) { |
| m_SendOverlapped.hEvent = WSACreateEvent(); | ||
| if (m_SendOverlapped.hEvent == NULL) { | ||
| LOGC(mglog.Error, log << CONID() << "IPE: WSACreateEvent failed with error: " << NET_ERROR); | ||
| throw CUDTException(MJ_SETUP, MN_NONE, NET_ERROR); |
There was a problem hiding this comment.
I think the minor code should be MN_NORES, as the new CChannel occurs only once in updateMux, which is called directly from bind and connect calls. Note that the documentation would have to be updated.
maxsharabayko
force-pushed
the
hotfix/wsasend-overlapped
branch
from
6147294 to
7492746
Compare
|
Rebased on the latest master ☝️ |
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check of the
WSASendresult, as reported in #973.Given that
::send(...)wan not observed to fail on Linux, adding a common::select(...)call for both Windows and Linux might decrease the performance.This PR uses Windows OverlappedIO API to wait for
WSASendto suceed.50 ms waiting time was chosen empiricaly. 10 ms produce more failures on sending.