Fix CRcvBuffer::countbytes() #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Priority: Low
Type: Bug
ethouris
reviewed
Sep 3, 2019
If len is negative, set rs to 0.
ethouris
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #776.
In
CRcvBuffer::getRcvReadyMsg, the number of removed packets/bytes is counted inside the loop. After the loop, the countBytes() is called. But the function might return inside the loo, thus not callingcountBytes().Fixes partially #836 issue 1
countBytes()is called for the part of the packet actually read, not the real size. Furthermore, if there is no more space in the buffer, the reading will continue, but a call to countBytes() will be skipped.and TSBPD log messages from TODO list.