Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Deleted deprecated API func srt_perfmon() #815

Merged
merged 1 commit into from
Aug 26, 2019

Conversation

maxsharabayko
Copy link
Collaborator

Deleted deprecated srt_perfmon(…) function.
Also the `[[deprecated]] C++14 keyword, when applied to a function, should be used as

[[deprecated]]
SRT_API int srt_perfmon(SRTSOCKET u, SRT_TRACEINFO * perf, int clear);

while it was used like

SRT_API int srt_perfmon(SRTSOCKET u, SRT_TRACEINFO * perf, int clear) [[deprecated]];

There is no reference to this function neither in API.md, not in API_functions.md, so nothing to clean there.

@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Aug 14, 2019
@maxsharabayko maxsharabayko added this to the v1.3.4 milestone Aug 14, 2019
@maxsharabayko maxsharabayko force-pushed the develop/deleteperfmon branch from e218daa to cde4ae6 Compare August 14, 2019 14:08
@ethouris
Copy link
Collaborator

ethouris commented Aug 15, 2019

"perfmon" is likely an old name. It's not in the API doc because deprecated functions are removed from the doc at the moment when they are declared deprecated. But deprecated stuff should be only removed in the next major release, I think, so I'd postpone this to 1.4.0.

AFAIK [[deprecated]] was initially planned to be applicable both in front and at the end of function declaration, but now all info I obtained has fixed it in the frontal position. In this case we might need to either have both deprecated in front, or simply leave all in the hands of compiler-specific attro. Embracing whole declaration won't be so easy because a comma inside may break the number of parameters (__VA_ARGS__ might suffice), and this will make it clumsy.

Since 4.8, AFAIR, gcc in C++11 mode supports attribute mapping through namespaced attributes, so [[gnu::deprecated]] will work also with C++11, even though the standard [[deprecated]] is available only in C++14.

@maxsharabayko maxsharabayko modified the milestones: v1.3.4, v1.4.0 Aug 15, 2019
@rndi rndi merged commit 140ebc5 into Haivision:master Aug 26, 2019
@maxsharabayko maxsharabayko deleted the develop/deleteperfmon branch October 29, 2019 12:27
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Nov 5, 2019
deprecated and unused. Missed in PR Haivision#815.
maxsharabayko added a commit to maxsharabayko/srt that referenced this pull request Nov 5, 2019
deprecated and unused. Missed in PR Haivision#815.
rndi pushed a commit that referenced this pull request Nov 5, 2019
deprecated and unused. Missed in PR #815.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants