Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Update timers on connection established. #745

Merged
merged 1 commit into from
Jul 3, 2019
Merged

[core] Update timers on connection established. #745

merged 1 commit into from
Jul 3, 2019

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jul 2, 2019 •
edited
Loading

CUDT::open sets initial values for timers. However the connection itself is established later. Need to update the timers.

For example, wrong value of m_ullLastRspTime_tk influences the LATEREXMIT functionality at the start (before PR #741). With FileCC this stops the slow start period too early and triggers exsessive packet retransmission.

17:02:01.904791: CUDT::open
17:02:03.200710: Connection established
17:02:03.310795: ENFORCED LATEREXMIT by ACK-TMOUT (scheduling): 6985342-6985356 (15 packets)
17:02:03.310809: FileCC: CHKTIMER, SLOWSTART:OFF, sndperiod=62500us AS mega/rate (rate=16)

@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Jul 2, 2019
@maxsharabayko maxsharabayko added this to the v.1.3.3 milestone Jul 2, 2019
@maxsharabayko maxsharabayko requested a review from ethouris July 2, 2019 08:58
ethouris
ethouris reviewed Jul 2, 2019
View reviewed changes
srtcore/core.cpp Outdated Show resolved Hide resolved
@maxsharabayko
[core] Update timers on connection established.
ed66548 
CUDT::open sets initial values for timers. However the connection itself is established later. Need to update the timers.
@maxsharabayko maxsharabayko force-pushed the hotfix/timers_on_connection_established branch from 8564367 to ed66548 Compare July 2, 2019 09:23
@maxsharabayko maxsharabayko mentioned this pull request Jul 3, 2019
Closed
@rndi rndi merged commit 2ecd6b1 into Haivision:master Jul 3, 2019
@maxsharabayko maxsharabayko mentioned this pull request Jul 4, 2019
Merged
@maxsharabayko maxsharabayko deleted the hotfix/timers_on_connection_established branch July 5, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris left review comments

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@maxsharabayko @ethouris @rndi