[apps] Fixed srt-file-transit (issue #645) #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
ethouris
reviewed
Apr 23, 2019
| @@ -180,7 +180,7 @@ int parse_args(FileTransmitConfig &cfg, int argc, char** argv) | |||
| return 2; | |||
| } | |||
|
|
|||
| cfg.chunk_size = stoul(Option<OutString>(params, "1316", o_chunk)); | |||
| cfg.chunk_size = stoul(Option<OutString>(params, "1456", o_chunk)); | |||
There was a problem hiding this comment.
Actually I doubt this option makes any sense anymore.
There was a problem hiding this comment.
I agree it is very unlikely to be used, but still is was in the previous file transmit version, so I'd better keep it, at least to minimize the work on these apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
srt-file-transmitissue, introduced by #598.Source::Read(…)now returns int and does not throw exceptions.Fixes #645