-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SRTO_IPV6ONLY option #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…+ do not set IPV6_V6ONLY on an IPV4 socket
merge latest changes from the trunk
maxsharabayko
requested changes
Mar 28, 2019
jeandube
reviewed
Mar 28, 2019
- correction of ipv6only default value - srt.h : correction of the operator& return condition, more readable
- now ipv6only is used for checking if an address is reusable
maxsharabayko
requested changes
Apr 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New socket option SRTO_IPV6ONLY
needs to be described in API.md.
maxsharabayko
added
[core]
Area: Changes in SRT library core
Type: Enhancement
Indicates new feature requests
labels
Apr 18, 2019
Add SRTO_IPV6ONLY option description
maxsharabayko
approved these changes
Apr 18, 2019
thomasjammet
added a commit
to MonaSolutions/srt
that referenced
this pull request
Apr 18, 2019
small correction of SRTO_IPV6ONLY option description, reported from PR Haivision#608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SRTO_IPV6ONLY to SRT_SOCKOPT for setting the IPV6_V6ONLY sockoption before the ::bind call
Also delete a "performance warning" in Visual Studio (srt.h)