Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix some indirect inclusion issues #2906

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

yomnes0
Copy link
Collaborator

@yomnes0 yomnes0 commented Mar 8, 2024

Last merge (PR #2868) introduced a bug which makes ffmpeg impossible to build with SRT because of an incorrect include of srt_compat.h in srt.h

@yomnes0 yomnes0 changed the title [core] Removed unnecessary include of srt_compat.h from srt.h [core] Removed unnecessary include of srt_compat.h from srt.h and logging.h Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.03%. Comparing base (9b8aaa6) to head (eed1d96).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2906      +/-   ##
==========================================
+ Coverage   64.84%   65.03%   +0.19%     
==========================================
  Files         101      101              
  Lines       17520    17525       +5     
==========================================
+ Hits        11360    11397      +37     
+ Misses       6160     6128      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This should avoid compilation issues with some compilers/platforms
@yomnes0 yomnes0 changed the title [core] Removed unnecessary include of srt_compat.h from srt.h and logging.h [core] Fix some indirect inclusion issues Mar 8, 2024
@maxsharabayko maxsharabayko added this to the v1.5.4 milestone Mar 8, 2024
@maxsharabayko maxsharabayko added Type: Bug Indicates an unexpected problem or unintended behavior [core] Area: Changes in SRT library core labels Mar 8, 2024
@maxsharabayko maxsharabayko merged commit 2c3f6f9 into Haivision:master Mar 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants