Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Minor fix of variable shadowing. #2726

Merged
merged 3 commits into from
Apr 25, 2023
Merged

[core] Minor fix of variable shadowing. #2726

merged 3 commits into from
Apr 25, 2023

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Apr 24, 2023 •
edited
Loading

Fixed variable shadowing in the core and tests.
Added -Wshadow=local in CMake build for GCC v7.0 and above.

Fixes #2725.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Apr 24, 2023
@maxsharabayko maxsharabayko added this to the v1.5.2 milestone Apr 24, 2023
@maxsharabayko maxsharabayko mentioned this pull request Apr 24, 2023
Closed
@ethouris
Copy link
Collaborator

He said that there are more in other places, too. Have you checked them all?

@maxsharabayko maxsharabayko force-pushed the hotfix/variable-shadowing branch 3 times, most recently from cc8d56a to c47596a Compare April 25, 2023 07:40
@maxsharabayko maxsharabayko requested a review from ethouris April 25, 2023 08:59
@maxsharabayko maxsharabayko force-pushed the hotfix/variable-shadowing branch from c8c8230 to fb0715d Compare April 25, 2023 10:38
@maxsharabayko maxsharabayko force-pushed the hotfix/variable-shadowing branch from fb0715d to 04a7da8 Compare April 25, 2023 11:40
ethouris
ethouris approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, althouth you might arm one of the CI build definitions with extra -Werror option so that it can break the build on any warning.

@maxsharabayko
Copy link
Collaborator Author

Looks ok, althouth you might arm one of the CI build definitions with extra -Werror option so that it can break the build on any warning.

Most Travis CI jobs already have -Werror (e.g. see here), should be enough for now.

@ethouris
Copy link
Collaborator

Ah, if so, then everything's alright.

@maxsharabayko maxsharabayko merged commit 66c86b1 into Haivision:master Apr 25, 2023
@maxsharabayko maxsharabayko deleted the hotfix/variable-shadowing branch April 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.5.2
Development

Successfully merging this pull request may close these issues.

[FR] Silence compiler warning for gcc -Wshadow=local
2 participants
@maxsharabayko @ethouris