Fix windows compile #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix windows compile remove pthread-win32 that I accidentally comitted
ethouris
reviewed
Jun 1, 2017
There was a problem hiding this comment.
This cannot be added in this form because the fixes cause also build break on Linux. However, thanks to your fix I was able to use some of your ideas, including some important documentation. I will submit my fix shortly. At least it was proven to work on MSVS 2013 and Cygwin with POSIX mode.
|
Alright, thanks. |
|
I'm going to close this in favor of #28 |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compile for windows. The instructions in the readme work now.
Fixes #1