[API] Added ENABLE_AEAD_API_PREVIEW build option to enable AEAD API. #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Enhancement
|
UDT.h changes of PR #2558. The file is public, although it is not the official API. |
|
Compatibility with v1.5.1.
|
|
I think the UDT API should be completely deprecated (and yes, removed in 1.6.0). Any C++ API for SRT (as extra convenient API) should obviously remain, but using the |
ethouris
reviewed
Dec 20, 2022
ethouris
reviewed
Dec 20, 2022
maxsharabayko
force-pushed
the
develop/aead-preview
branch
3 times, most recently
from
430ebd8 to
17af990
Compare
maxsharabayko
changed the title
Reverting Haivision#2558, although udt.h is not the official SRT API.
maxsharabayko
force-pushed
the
develop/aead-preview
branch
from
17af990 to
a89a48a
Compare
ethouris
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to preserve the API/ABI compatibility between patch releases of SRT the AEAD feature is disabled by default.
ENABLE_AEAD_PREVIEWbuild option is introduced to enable the API for those who want to try the feature scheduled for v1.6.0.