[core] Fix CRcvBuffer last position in getTimespan_ms(). #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Bug
ethouris
reviewed
Dec 13, 2022
ethouris
reviewed
Dec 13, 2022
ethouris
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the AES-GCM encryption mode, the last position in the receiver buffer can be dropped.
The assertion, placed in the
CRcvBuffer::getTimespan_ms(), is updated to reflect the new behavior.Furthermore, the search for the last position is improved.
The
CRcvBuffer::getTimespan_ms()is used to expose the value in statistics: either instantaneous or a smothed average. On decryption failure, the connection will get broken, so there is probably not much sense in searching for the last valid position. However, it is more correct from the logic of the receiver buffer, because it does not control the connection state.