[AEAD] Set AES-GCM auth in the KM message. #2492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Auth field in the case of GCM must contain not the HCRYPT_AUTH_NONE, but HCRYPT_AUTH_GCM.
According to RFC 5647, "If AES-GCM is selected as the encryption algorithm for a given tunnel, AES-GCM MUST also be selected as the Message Authentication Code (MAC) algorithm. Conversely, if AES-GCM is selected as the MAC algorithm, it MUST also be selected as the encryption algorithm".
Fields Affected
Legend
❌ - no changes.
❗ - changes needed.
4: AES-GCM ➕
0: None or KEKI indexed crypto context.
1: AES-GCM.
Related issue #2339.
Related SRT Internet Draft updates: Haivision/srt-rfc#115.