Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCryptoControl: Partially removed dependency on CUDT. #2424

Merged

Conversation

maxsharabayko
Copy link
Collaborator

CCryptoControl takes too much responsibility, and also handles sending of KM packets via a CUDT socket class.
Ideally, the CUDT should send everything itself, and only ask CCryptoControl if something has changed and an exchange of updated keys is required. However, it is not easy to decouple this logic straight away.
This PR removed reference to CUDT where possible. When CUDT asks CCryptoControl to send something, it just passes a pointer to itself so that CCryptoControl can call the sending function.
This should at least allow using CCryptoControl in a unit test without mocking CUDT.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Aug 3, 2022
@maxsharabayko maxsharabayko added this to the Next Release milestone Aug 3, 2022
srtcore/crypto.h Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko force-pushed the develop/ccryptocontrol-cudt-dep branch from 2d482ca to 54fec45 Compare August 12, 2022 09:33
@maxsharabayko maxsharabayko merged commit fe98265 into Haivision:master Aug 12, 2022
@maxsharabayko maxsharabayko deleted the develop/ccryptocontrol-cudt-dep branch August 12, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants