CCryptoControl: Partially removed dependency on CUDT. #2424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCryptoControl
takes too much responsibility, and also handles sending of KM packets via aCUDT
socket class.Ideally, the CUDT should send everything itself, and only ask
CCryptoControl
if something has changed and an exchange of updated keys is required. However, it is not easy to decouple this logic straight away.This PR removed reference to
CUDT
where possible. WhenCUDT
asksCCryptoControl
to send something, it just passes a pointer to itself so thatCCryptoControl
can call the sending function.This should at least allow using
CCryptoControl
in a unit test without mockingCUDT
.