Improving CUnitQueue performance: don't adjust mcount #2405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted undisputed changes from PR #2395.
Do not adjust taken units in
CUnitQueue::increase()
The re-estimation of the number of units taken in the
CUnitQueue
was previously done as a workaround for synchronization issues around simultaneous access toCUnitQueue::m_iCount
.Those issues should be fixed by now, e.g. #1333.
No point in this CPU-heavy loop anymore.
CRcvQueue
now tracks IP version instead ofCUnitQueue
Previously
CUnitQueue
was tracking IP version. The value was submitted inCRcvQueue::init(..)
, and used byCRcvQueue::worker(..)
thread. There is no use for the value in theCUnitQueue
itself.Therefore, moved to
CRcvQueue
.Minor clean-up fix rethrowing an exception.
An exception was being caught in a named variable, while it was not referenced.