Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] reject if streamid of group conflict #2205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Dec 8, 2021

Fix part of #1838

@maxsharabayko maxsharabayko added this to the v1.4.5 milestone Dec 8, 2021
@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Dec 8, 2021
@maxsharabayko maxsharabayko modified the milestones: v1.4.5, v1.5.0 May 2, 2022
@maxsharabayko maxsharabayko added the Type: Enhancement Indicates new feature requests label May 2, 2022
@gou4shi1 gou4shi1 force-pushed the reject-if-streamid-of-group-conflict branch from 56750d6 to 7b14f5a Compare May 7, 2022 05:00
@maxsharabayko
Copy link
Collaborator

The targeted situation is two (or more) independent groups of callers that happen to have the same Group ID.
If those were configured at least with different StreamIDs, the value can be used to avoid accepting a connection from a different group after a connection from the first one is accepted.
Once the first group member connection is accepted, its Stream ID (if set) is saved for the group. Further member connection requests with a different Stream ID are rejected.

Will a connection be rejected if StreamID on of the listening group is not configured before it starts listening?
Could that be rather managed via SRT listener callback?

@gou4shi1
Copy link
Contributor Author

gou4shi1 commented Sep 4, 2023

Will a connection be rejected if StreamID on of the listening group is not configured before it starts listening?

Sorry but I couldn't get this point.

Could that be rather managed via SRT listener callback?

Did you mean srt_connect_callback()? In the listener side, it seems only be called in completeBrokenConnectionDependencies()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants