Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Removed ThreadName(const char*). #2113

Merged
merged 4 commits into from
Sep 2, 2021
Merged

[core] Removed ThreadName(const char*). #2113

merged 4 commits into from
Sep 2, 2021

Conversation

maxsharabayko
Copy link
Collaborator

To avoid passing a NULL pointer to ThreadName constructor or ThreadName::set(const char*) function now only string& argument is expected.

@maxsharabayko
[core] Removed ThreadName(const char*).
3a07a8d 
Now only string& can be passed to avoid checking for NULL.
@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Aug 31, 2021
@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Aug 31, 2021
@maxsharabayko maxsharabayko marked this pull request as draft August 31, 2021 17:31
@maxsharabayko
Explicitely defined copy constructor and
ffcd84c 
copy assignment operator private
@maxsharabayko maxsharabayko marked this pull request as ready for review September 2, 2021 11:00
@codecov-commenter

This comment has been minimized.

Sign in to view
@maxsharabayko maxsharabayko merged commit 2243388 into Haivision:master Sep 2, 2021
@maxsharabayko maxsharabayko deleted the develop/threadname-string branch September 2, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlsantiago0 jlsantiago0 jlsantiago0 approved these changes

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@maxsharabayko @codecov-commenter @jlsantiago0