Fix build for Linux GLIBC-2.8 and earlier. #2103
Conversation
| localid = epoll_create1(flags); | ||
|
|
||
| // NOTE: epoll_create1() and EPOLL_CLOEXEC were introduced in GLIBC-2.9. | ||
| // So earlier versions of GLIBC, must use epoll_create() and set |
There was a problem hiding this comment.
I'm really interested what Linux distribution with glibc earlier than 2.9 needs to support libsrt?
glibc-2.9 was released in 2008.
There was a problem hiding this comment.
Many embedded projects have older runtime libraries and toolchains. For instance Makito Classic is <glibc-2.9.
CentOS5 and earlier have <glibc-2.9. Many projects that distribute linux binaries will compile with an older linux distribution so that they can ensure that their program will run on a wide variety of Linux distros. For instance when I distribute HVIORouter, I currently build it with CentOS6 for distribution, and up until very recently with CentOS5.
maxsharabayko
added
[build]
|
After removing the invalid and incorrect comment about the negative return of epoll_create1(), the patch should be good. |
|
@jlsantiago0 I can test build your PR. For glibc I need to verify. |
|
@jlsantiago0 Previous comment was aimed at PR#2104 :-) |
epoll_create1()andEPOLL_CLOEXECwere introduced inGLIBC-2.9.This patch fixes the build for
GLIBC-2.8and earlier targets.Tested on CentOS5.