Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build for Android. #2100

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Fix Build for Android. #2100

merged 1 commit into from
Aug 25, 2021

Conversation

jlsantiago0
Copy link
Contributor

@jlsantiago0 jlsantiago0 commented Aug 24, 2021

Some versions of CMake set CMAKE_SYSTEM_NAME to "Android" check CMAKE_SYSTEM_NAME case insensitively for that string.

Also with the new atomic functions being used by the SRT library, we need to link the atomic library for Android targets.

@maxsharabayko
Copy link
Collaborator

@jlsantiago0 Thank you for the fix!
There is one more way to perform a case-insensitive comparison. But it would require an additional variable to be set.

string(TOLOWER ${CMAKE_BUILD_TYPE} LOWERCASE_CMAKE_BUILD_TYPE)
set_if(ANDROID ${LOWERCASE_CMAKE_BUILD_TYPE} MATCHES "android")

Therefore your solution looks cleaner to me.

@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Aug 25, 2021
@maxsharabayko maxsharabayko added [build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior labels Aug 25, 2021
@maxsharabayko maxsharabayko merged commit da70624 into Haivision:master Aug 25, 2021
@jlsantiago0 jlsantiago0 deleted the android-build-fixes branch August 25, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants