Fixed SHUTDOWN message with a wrong (uninitialized) DST socket ID #2073
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDT::m_PeerID
is not initialized by the constructor. It has a random (garbage) value until set during HS.When a caller with a passphrase tries to connect to a listener without a passphrase, the listener sends a rejection conclusion HS.
The caller, receiving the HS, sees the rejection code (in
CUDT::processAsyncConnectRequest(..)
), and returns from the function without initializingm_PeerID
.As
processAsyncConnectRequest(..)
returns false, a SHUTDOWN control packet is sent fromCRendezvousQueue::updateConnStatus(..)
.But destination SRT socket ID is still not initialized and may contain some garbage value, that could match some existing SRT socket ID on the listener side.
In the worst case, it could lead to a closure of a different valid connection existing on the same port, when SHUTDOWN is sent from the same IP.