Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Set CLOEXEC for epoll on Linux #2062

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

quink-black
Copy link
Contributor

epoll_create1() was added to the kernel in version 2.6.27. Library
support is provided in glibc starting with version 2.9 which was
released at the year of 2008.

epoll_create1() was added to the kernel in version 2.6.27. Library
support is provided in glibc starting with version 2.9 which was
released at the year of 2008.
@codecov-commenter

This comment has been minimized.

@maxsharabayko
Copy link
Collaborator

Some Additional Info

A note (reasoning) to replacing epoll_create with epoll_create1.
From epoll_create2 manpage:

epoll_create() creates a new epoll(7) instance. Since Linux 2.6.8 (August 14, 2004), the size argument is ignored, but must be greater than zero..

@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Jul 22, 2021
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Jul 22, 2021
@maxsharabayko maxsharabayko merged commit a34aa08 into Haivision:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants