Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Added compile_commands.json to .gitignore #2031

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

gou4shi1
Copy link
Contributor

@gou4shi1 gou4shi1 commented Jun 1, 2021

Let CMake generate Compilation Database for LSP editor plugins.

@maxsharabayko
Copy link
Collaborator

Can't this flag be passed to CMake explicitly?
Like cmake . -DCMAKE_EXPORT_COMPILE_COMMANDS=ON

@maxsharabayko maxsharabayko added this to the v1.4.4 milestone Jun 1, 2021
@maxsharabayko maxsharabayko added the [build] Area: Changes in build files label Jun 1, 2021
@gou4shi1
Copy link
Contributor Author

gou4shi1 commented Jun 1, 2021

Can't this flag be passed to CMake explicitly?

sure, I just think it's a common requirement, LOL

@gou4shi1
Copy link
Contributor Author

gou4shi1 commented Jun 1, 2021

and It's useful to gitignore compile_commands.json

@quink-black
Copy link
Contributor

You can set the CMAKE_EXPORT_COMPILE_COMMANDS environment variable so it works for all cmake projects.

export CMAKE_EXPORT_COMPILE_COMMANDS=ON

Approve for adding compile_commands.json to gitignore.

@gou4shi1 gou4shi1 changed the title [build] generate compile_commands.json [build] Added compile_commands.json to .gitignore Jun 2, 2021
@maxsharabayko maxsharabayko added the Type: Maintenance Work required to maintain or clean up the code label Jun 2, 2021
@maxsharabayko maxsharabayko merged commit b4a5887 into Haivision:master Jun 2, 2021
@gou4shi1 gou4shi1 deleted the generate_compile_commands branch June 22, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[build] Area: Changes in build files Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants