[core] Added srt::sync::genRandomInt(..) #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Enhancement
Previously a custom __MINGW__ preprocessor definition was used. It was defined in udt.h, and not included everywhere.
for a uniform way to get a random integer from the range. If C++11 is enabled, uniform_int_distribution and random_device are used.
maxsharabayko
force-pushed
the
develop/cxx11-random
branch
from
3fdc26c to
d2f7ac1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Fixed MinGW Build
Commit no. 1.
Previously a custom definition
__MINGW__was defined inudt.h. However,udt.h. was not included in every source file, which uses__MINGW__preprocessor definition, includingsrt.h.According to this table MinGW defines
__MINGW32__preprocessor definition.Now simply using
__MINGW32__preprocessor definition in relevant places.2. Thread-Safe Random
Commit no. 2.
POSIX
rand()is not thread safe.This PR makes use of
rand_r(unsigned int *seed)instead.std::random_deviceandstd::uniform_ditribution;rand_r(unsigned int *seed)is used instead.rand()as there is norand_r(..)available.TODO
rand_ron MinGW? - usingrand().Fixes #1825.
Maybe improves the situation with #1838.