TSBPD logic extracted from CRcvBuffer. #1968
Conversation
Refactoring, no functional changes are expected. New CTsbpdTime class to operate with TSBPD timing.
maxsharabayko
added
Type: Maintenance
srtcore/tsbpd_time.h
Outdated
| /// @brief Get TSBPD base time considering possible carryover | ||
| /// when packet timestamp is overflown and continues from 0. |
There was a problem hiding this comment.
Not sure what you mean here. Does this function get the TSBPD base time value in order to compare with the timestamp for a packet to see if it has exceeded the wrap value (and therefore should be re-evaluated to continue from 0 as it should)?
Also, is this inversion in function names intentional?
time_point getPktTsbPdBaseTime(uint32_t usPktTimestamp) const;
time_point getTsbPdTimeBase(uint32_t usPktTimestamp) const;
There was a problem hiding this comment.
@stevomatthews This naming is something that also looks confusing to me and I would love to improve,
Let us say that Packet TSBPD time is the time when a packet can be extracted from the receiver buffer.
Essentially, it consists of usPktTsbpdTime = usTsbpdTimeBase + usPktTimeStamp + usTsbpdDelay + usDrift,
where usTsbpdTimeBase takes possible packet timestamp carryover into account.
Then:
getTsbPdTimeBase(uint32_t usPktTimestamp)returnsusTsbpdTimeBasefor a packet (with possible carryover).getPktTsbPdBaseTime(uint32_t usPktTimestamp)returnsusTsbpdTimeBase + usPktTimeStamp.getPktTsbPdTime(uint32_t usPktTimestamp)returnsusTsbpdTimeBase + usPktTimeStamp + usTsbpdDelay + usDrift.
Co-authored-by: stevomatthews <smatthews@haivision.com>
Extracted refactoring around
CRcvBufferand TSBPD logic from PR #1965. No functional changes are expected.The new
CTsbpdTimeclass is now to operate with TSBPD timing.