-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved receiver buffer implementation #1964
Improved receiver buffer implementation #1964
Conversation
6aece5a
to
8d9b68a
Compare
5dd1bbb
to
8ddd02f
Compare
32e1542
to
a8f4551
Compare
|
||
template <class T> | ||
class FixedArray | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- utilities.h is included by common.h
- common.h use something defined by utilities.h, e.g., HAVE_FULL_CXX11
- Something defined by common.h can be useful for utilities.h, e.g., SRT_ASSERT, SRT_STATIC_ASSERT, but can't due to circular header include
utilities.h is more than utility, it needs some cleanup work. Before that, I prefer the "include what you use" method, and use a separate header file. Of course, the cleanup work can be done after the patch. So the comments above doesn't related to the patch strictly.
2efc5dd
to
841534f
Compare
3f6e4b7
to
852f583
Compare
852f583
to
ba0c9ee
Compare
4088b79
to
cac019c
Compare
cac019c
to
a4bc6a0
Compare
37fac37
to
22805bd
Compare
738629a
to
9ab7581
Compare
Only the new RCV buffer (PR Haivision#1964) is affected.
Only the new RCV buffer (PR #1964) is affected.
Yes, this optimization is missing. |
This PR introduces a new receiver buffer.
To start with, both old and new versions of the receiver buffer are available.
A build option
ENABLE_NEW_RCVBUFFER
can be used to build SRT with the new version.Main Features
O
of a data packet, allowing to read packets out of order. It is not working properly with the old receiver buffer.Addresses #1674
Description to be improved.
TODO
Transmission.FileUpload
test.-DENABLE_NEW_RCVBUFFER=OFF
.CRcvBufferNew::getRcvDataSize(..)
: counting acknowledged packets requires modifications.