Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor cleanup #1938

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Minor cleanup #1938

merged 2 commits into from
Apr 14, 2021

Conversation

quink-black
Copy link
Contributor

  1. sync_posix: make global variable and function file scope
  2. replace static_assert by SRT_STATIC_ASSERT

@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Apr 14, 2021
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Apr 14, 2021
@maxsharabayko maxsharabayko merged commit 109f667 into Haivision:master Apr 14, 2021
@ethouris
Copy link
Collaborator

Just for future: in C++ global constants are static by default. You need to mark them extern to make them external.

@quink-black
Copy link
Contributor Author

Just for future: in C++ global constants are static by default. You need to mark them extern to make them external.

OK I missed the "constant" part. Today I learned, thanks! However, I still like to specify 'static' explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@quink-black @ethouris @maxsharabayko