Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for SRT socket options API #1929

Merged
merged 6 commits into from
Aug 2, 2021

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Apr 9, 2021

This PR contains:

  1. Unit tests (test_socket_options.cpp):

    • Min values
    • Max values
    • Default values
    • Invalid values
    • Restrictions: after bind, after connection.
  2. Some fixes for socket options API (to be merged separately)

Derived PRs: #1921, #1922, #1925, #1931, #1939, #1940, #1941, #1948, #1954, #1956.

TODO

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [tests] Area: Unit tests labels Apr 9, 2021
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Apr 9, 2021
@maxsharabayko maxsharabayko self-assigned this Apr 9, 2021
@maxsharabayko maxsharabayko marked this pull request as draft April 9, 2021 15:57
@maxsharabayko maxsharabayko force-pushed the tests/sockopts branch 2 times, most recently from 5239378 to b33aa39 Compare April 16, 2021 10:26
@maxsharabayko maxsharabayko modified the milestones: v1.4.3, v1.4.4 Apr 19, 2021
@maxsharabayko
Copy link
Collaborator Author

maxsharabayko commented Jul 26, 2021

TODO:

@maxsharabayko maxsharabayko marked this pull request as ready for review August 2, 2021 14:34
@maxsharabayko maxsharabayko merged commit 5ac27a3 into Haivision:master Aug 2, 2021
@maxsharabayko maxsharabayko deleted the tests/sockopts branch August 2, 2021 15:15
@maxsharabayko maxsharabayko changed the title Unit tests for SRT socket options API (WIP) Unit tests for SRT socket options API Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[tests] Area: Unit tests Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant