Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Added more logs around accept errors #1883

Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Mar 23, 2021

Fixes #1880

Added more logs around errors from srt_accept.

@ethouris ethouris requested a review from maxsharabayko March 23, 2021 10:22
@ethouris ethouris added [core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code labels Mar 23, 2021
@ethouris ethouris changed the title [core][test] Fixed accepted socket leak on wrong accept call. Added more logs around accept errors [core] Added more logs around accept errors Mar 23, 2021
@mbakholdina mbakholdina added this to the v1.4.3 milestone Mar 23, 2021
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider minor improvements to the perspicuity of logs.

srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
srtcore/api.cpp Show resolved Hide resolved
srtcore/api.cpp Outdated Show resolved Hide resolved
Co-authored-by: Maxim Sharabayko <maxlovic@gmail.com>
@maxsharabayko maxsharabayko merged commit b9d568e into Haivision:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[maint] Improve error information displayed at the accept activities
3 participants