[core] Added restrictions on pktseq/msgno fields in srt_sendmsg2 call #1879
Conversation
ethouris
added
[API]
There was a problem hiding this comment.
The API behavior is changed by this PR.
Previously both pktseq and msgno were ignored. This behavior is also described in the docs, although you have to know where to look.
int32_t pktseq; // sequence number of the first packet in received message (unused for sending)
int32_t msgno; // message number (output value for both sending and receiving)
With this change API expects the user to provide the default values for pktseq and msgno, returning the error otherwise. Whether it is good or bad - hard to say.
Potentially to remain more or less close to the existing behavior (SRT v1.4.2 and prior) the default values could be set in the beginning, instead of validating those values are default-initialized. Then if sending succeeds, the actual values are set to msgno and pktseq. In case of sending error default values are returned.
|
So maybe another proposal: these fields will be forcefully set to default values. This way, whatever you set there, will be effectively ignored. |
Fixes #1810