Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed: lock around ackmessage #1849

Merged

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Mar 8, 2021

The problem: ackMessage was called without locking a group from the handler of UMSG_ACK, which might cause wrong timing for update of the field holding this last message number updated from ACK.

@ethouris ethouris requested a review from maxsharabayko March 8, 2021 15:52
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Mar 8, 2021
@maxsharabayko maxsharabayko added [core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior labels Mar 8, 2021
@maxsharabayko maxsharabayko merged commit d1d351d into Haivision:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants