Fixed bug: wrong size setting for StringStorage. Added UT. #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
Comment on lines
+225
to
+229
| char example_ac1[] = "example_long"; | ||
| char example_ac2[] = "short"; | ||
| char example_ac3[] = "example_longer"; | ||
| char example_acx[] = "example_long_excessively"; | ||
| char example_ace[] = ""; |
Comment on lines
+251
to
+255
| string example_s1 = "example_long"; | ||
| string example_s2 = "short"; | ||
| string example_s3 = "example_longer"; | ||
| string example_sx = "example_long_excessively"; | ||
| string example_se = ""; |
There was a problem hiding this comment.
const- maybe just
string example_s1(example_ac1)or the other way:example_s1.c_str()covers the case of rawchar array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: When setting a string with shorter size than the one that exists, characters past the alleged size may remain from previous one.
Also added UT for StringStorage type.