[build] Fixed possibility to compile examples with C++03 standard #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
Priority: High
Type: Bug
Co-authored-by: stevomatthews <smatthews@haivision.com>
CMakeLists.txt
Outdated
Comment on lines
418
to
420
| #if (DEFINED USE_CXX_STD) | ||
| # message(FATAL_ERROR "USE_CXX_STD can be set only when ENABLE_CXX11 is on") | ||
| #endif() |
docs/DevelopersGuide.md
Outdated
Comment on lines
91
to
104
| 2. The examples (to be enabled by `--enable-examples`) require either C++03 or C89 standard. | ||
| 3. The following require C++11 standard: | ||
| * demo applications | ||
| * testing applications (to be enabled by `--enable-testing`) | ||
| * unit tests (to be enabled by `--enable-unittests`) | ||
|
|
||
| Note that C++11 standard will be enforced if you have enabled applications | ||
| and haven't specified the C++ standard explicitly. When you have an old compiler | ||
| that does not support C++11 and you want to compile as many parts as possible, | ||
| the simplest way is to use the following options: | ||
|
|
||
| ``` | ||
| ./configure --disable-apps --use-c++-std=03 --enable-examples | ||
| ``` |
There was a problem hiding this comment.
CMake should be the default build system. TCL is not available on Windows by default.
cmake . -DENABLE_APPS=ON and so on
docs/DevelopersGuide.md
Outdated
Comment on lines
102
to
106
| ``` | ||
| ./configure --disable-apps --use-c++-std=03 --enable-examples | ||
| ``` | ||
|
|
||
| Note also that there are several other options that, when enabled, may require that the SRT library be compiled using C++11 standard (`--enable-stdc++-sync` for example). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
The examples were enforced to be compiled with C++11 standard even though they are written in C++03 or even in C style.
After the fix it is possible to compile the library and examples using a compiler that is not C++11 capable using options: