Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apps] Created an example for non-blocking client #1753

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

maxsharabayko
Copy link
Collaborator

Pretty straightforward as srt_cleanup() is better to be called on every return.

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [apps] Area: Test applications related improvements labels Jan 20, 2021
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Jan 20, 2021
@maxsharabayko maxsharabayko self-assigned this Jan 20, 2021
@maxsharabayko maxsharabayko force-pushed the develop/example-client branch from cffe83b to 31efde1 Compare January 20, 2021 16:11
@ethouris
Copy link
Collaborator

Why not rather adding non-blocking support to existing examples?

Also: it's not exactly a good idea to not subscribe for ERR readiness, just for checking.

@maxsharabayko
Copy link
Collaborator Author

Why not rather adding non-blocking support to existing examples?

For simplicity. Mixing both blocking and non-blocking would make an example way too complicated. While the example is intended as a quick start for someone not yet very familiar with SRT or even networking.

Also: it's not exactly a good idea to not subscribe for ERR readiness, just for checking.

Added.

@maxsharabayko maxsharabayko merged commit 68edf20 into Haivision:master Jan 21, 2021
@maxsharabayko maxsharabayko deleted the develop/example-client branch January 21, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[apps] Area: Test applications related improvements Type: Enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants