Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting sendBackup_CheckParallelLinks(..) #1751

Merged
merged 4 commits into from
Jan 22, 2021
Merged

Splitting sendBackup_CheckParallelLinks(..) #1751

merged 4 commits into from
Jan 22, 2021

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jan 19, 2021 •
edited
Loading

The function sendBackup_CheckParallelLinks was doing two quite independent things:

  • Retrying sending a packet in case not a single send operation has succeeded, but there are active links. Also blocking the srt_sendmsg2 in blocking mode, and signalling an error in non-blocking mode.
  • Silencing redundant active links if the main link is stable.
  1. The first logic is now moved to sendBackup_RetryWaitBlocked,
  2. The second logic is now moved to sendBackup_SilenceRedundantLinks

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Jan 19, 2021
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Jan 19, 2021
@maxsharabayko maxsharabayko self-assigned this Jan 19, 2021
@maxsharabayko maxsharabayko marked this pull request as ready for review January 22, 2021 12:44
@maxsharabayko maxsharabayko merged commit b2d35fc into Haivision:master Jan 22, 2021
@maxsharabayko maxsharabayko deleted the develop/main-backup-parallel branch January 22, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris approved these changes

Assignees

@maxsharabayko maxsharabayko

Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsharabayko @ethouris