Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Main-backup: renaming member link arrays #1744

Merged
merged 10 commits into from
Jan 19, 2021
Merged

[core] Main-backup: renaming member link arrays #1744

merged 10 commits into from
Jan 19, 2021

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Jan 14, 2021 •
edited
Loading

List of changes:

  • vector<gli_t> idlers -> idleLinks
  • vector<SRTSOCKET> pending -> pendingSockets
  • vector<gli_t> sendable -> activeLinks
  • vector<Sendstate> sendstates not used in the backup mode, removed.
  • vector<gli_t> unstable - unstableLinks
  • uint16_t max_sendable_weight -> maxActiveWeight

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Jan 14, 2021
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Jan 14, 2021
@maxsharabayko maxsharabayko self-assigned this Jan 14, 2021
ethouris
ethouris reviewed Jan 14, 2021
View reviewed changes
srtcore/group.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Jan 14, 2021
View reviewed changes
srtcore/group.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Jan 14, 2021
View reviewed changes
srtcore/group.h Outdated Show resolved Hide resolved
@maxsharabayko maxsharabayko marked this pull request as ready for review January 19, 2021 14:34
ethouris
ethouris reviewed Jan 19, 2021
View reviewed changes
srtcore/group.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Jan 19, 2021
View reviewed changes
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok, just this one comment contains many typos; I proposed a more concise form.

@maxsharabayko maxsharabayko merged commit b665e35 into Haivision:master Jan 19, 2021
@maxsharabayko maxsharabayko deleted the develop/main-backup-states branch January 19, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris approved these changes

Assignees

@maxsharabayko maxsharabayko

Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsharabayko @ethouris