Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apps] Refactored stats tables with universal printers #1743

Merged

Conversation

ethouris
Copy link
Collaborator

Replaces #1551

This introduces the stats table, which contains the category-shortname labeling for json and longname (usually same as the field name in CBytePerfMon) for csv format.

The both json and csv formatters now use the statements from the table instead of manually crafted headers, labels and values.

@ethouris ethouris added Type: Maintenance Work required to maintain or clean up the code [apps] Area: Test applications related improvements labels Jan 14, 2021
@ethouris ethouris self-assigned this Jan 18, 2021
@ethouris ethouris added this to the v1.4.3 milestone Jan 18, 2021
Comment on lines +441 to +445
if (Option("pretty"))
{
pretty_cr = "\n";
pretty_tab = "\t";
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to enable this pretty stats output? Via -statspf option?
srt-live-transmit.md documentation might need an update.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-statspf json,pretty. Yes, you're right.

@maxsharabayko
Copy link
Collaborator

CodeFactor minor issues:
Redundant blank line on lines 382 and 408 of apputil.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[apps] Area: Test applications related improvements Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants