Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Minor refactoring of CheckRunningStability #1713

Merged
merged 3 commits into from
Dec 17, 2020
Merged

[core] Minor refactoring of CheckRunningStability #1713

merged 3 commits into from
Dec 17, 2020

Conversation

maxsharabayko
Copy link
Collaborator

  • Renamed m_tsTmpActiveTime to m_tsTmpActiveSince;
  • Minor refactoring of CUDTGroup::sendBackup_CheckIdleTime(..) to improve readability.

@maxsharabayko maxsharabayko added Type: Maintenance Work required to maintain or clean up the code [core] Area: Changes in SRT library core labels Dec 15, 2020
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Dec 15, 2020
ethouris
ethouris reviewed Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the blocked setting "already true" as not necessary.

@maxsharabayko
Copy link
Collaborator Author

Consider removing the blocked setting "already true" as not necessary.

Done.

@maxsharabayko maxsharabayko merged commit 88affe5 into Haivision:master Dec 17, 2020
@maxsharabayko maxsharabayko deleted the develop/main-backup branch December 17, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris left review comments

Assignees
No one assigned
Labels
[core] Area: Changes in SRT library core Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@maxsharabayko @ethouris