Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fixed order of group member state change before write ready #1695

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Dec 4, 2020

The problem:

Write-readiness was set before the group state was upgraded from PENDING to IDLE. This brought a risk that the connecting function could exit before this state is changed and also the sending function might start the operation, catching all links PENDING, which resulted in error, even though the links are connected and the sending operation should at least try to send.

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #1695 (1f199a3) into master (fda8b7b) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1695      +/-   ##
==========================================
- Coverage   60.51%   60.45%   -0.07%     
==========================================
  Files          78       78              
  Lines       17444    17444              
==========================================
- Hits        10556    10545      -11     
- Misses       6888     6899      +11     
Impacted Files Coverage Δ
srtcore/core.cpp 54.86% <100.00%> (-0.05%) ⬇️
srtcore/congctl.cpp 81.02% <0.00%> (-3.08%) ⬇️
srtcore/window.cpp 81.81% <0.00%> (-1.30%) ⬇️
srtcore/list.cpp 76.23% <0.00%> (-0.58%) ⬇️
srtcore/api.cpp 48.66% <0.00%> (-0.06%) ⬇️
test/test_bonding.cpp 98.84% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda8b7b...1f199a3. Read the comment docs.

@ethouris ethouris self-assigned this Dec 7, 2020
@ethouris ethouris added [core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior labels Dec 7, 2020
@maxsharabayko maxsharabayko added this to the v1.4.3 milestone Dec 7, 2020
@maxsharabayko maxsharabayko merged commit 82ada5d into Haivision:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[core] Area: Changes in SRT library core Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants