-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Test apps improvements + build break fixes with logging off #1638
[test] Test apps improvements + build break fixes with logging off #1638
Conversation
isoption = false; | ||
} | ||
|
||
if (moreoptions && isoption) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bugfix for handling numeric negative arguments in option parser.
} | ||
|
||
transmit_retry_connect = stoi(retryphrase); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a -retry
option that stubbornly tries to reconnect when the connection was broken. The argument is a number of times to retry, -1 is unlimited, when a
is added to the number, it means it should retry no matter what the reason was (otherwise it only retries if it was timeout).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
The question is how to qualify this PR.
- It touches the core, but only around exposing some logging staff to apps if built with logging disabled.
- It fixes building of testing apps.
- It fixes a bug in Options Parser
- It adds the new command-line option
-retry
to srt-test-live.
[tests]
is for unit tests. Testing apps are [apps]
.
So either [core]
or [apps]
🤔
Touching [core] should be of higher importance, but those changes are pretty minor, and changes to [apps] are more notable. Therefore let it be [apps]. |
Changes summary: