Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Test apps improvements + build break fixes with logging off #1638

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Nov 6, 2020

Changes summary:

  1. Fixes for compiling with ENABLE_LOGGING=OFF that got a build break (some may additionally follow in the application files):
  • srtcore/common.cpp
  • srtcore/crypto.cpp
  • srtcore/crypto.h
  1. Small bugfixes and improvements in the test application, mainly connected with ability to test with unusual scenarios:
  • apps/apputil.cpp -- Bugfix for correct handling -1 numbers in option arguments
  • testing/srt-test-live.cpp -- Added retry option
  • testing/srt-test-mpbond.cpp -- Fixed build break when logging is on
  • testing/testmedia.cpp -- Fix for proper handling async group connection; handler for retry

@ethouris ethouris added the Type: Maintenance Work required to maintain or clean up the code label Nov 6, 2020
isoption = false;
}

if (moreoptions && isoption)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix for handling numeric negative arguments in option parser.

}

transmit_retry_connect = stoi(retryphrase);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a -retry option that stubbornly tries to reconnect when the connection was broken. The argument is a number of times to retry, -1 is unlimited, when a is added to the number, it means it should retry no matter what the reason was (otherwise it only retries if it was timeout).

@maxsharabayko maxsharabayko self-assigned this Nov 6, 2020
@maxsharabayko maxsharabayko added the [core] Area: Changes in SRT library core label Nov 6, 2020
Copy link
Collaborator

@maxsharabayko maxsharabayko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
The question is how to qualify this PR.

  • It touches the core, but only around exposing some logging staff to apps if built with logging disabled.
  • It fixes building of testing apps.
  • It fixes a bug in Options Parser
  • It adds the new command-line option -retry to srt-test-live.

[tests] is for unit tests. Testing apps are [apps].
So either [core] or [apps] 🤔

@maxsharabayko
Copy link
Collaborator

Touching [core] should be of higher importance, but those changes are pretty minor, and changes to [apps] are more notable. Therefore let it be [apps].

@maxsharabayko maxsharabayko added [apps] Area: Test applications related improvements and removed [core] Area: Changes in SRT library core labels Nov 6, 2020
@maxsharabayko maxsharabayko merged commit 172d91f into Haivision:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[apps] Area: Test applications related improvements Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants