[core] Moved ACK sending to CUDT::sendCtrlAck #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Maintenance
ethouris
reviewed
Oct 29, 2020
srtcore/core.cpp
Outdated
| if (CSeqNo::seqcmp(ack, m_iRcvLastAck) > 0) | ||
| { | ||
| const int32_t first_seq ATR_UNUSED = ackDataUpTo(ack); | ||
| leaveCS(m_RcvBufferLock); |
There was a problem hiding this comment.
As this is now part of the function, I think you might consider changing the lock on m_RcvBuffferLock to use scope-based tools, UniqueLock and InvertedLock. Especially if this is refax and aimed at improving readability and error-resistance.
There was a problem hiding this comment.
Replaced critical section with UniqueLock.
maxsharabayko
force-pushed
the
develop/send-ctrl-ack
branch
from
0038dd7 to
459627c
Compare
in CUDT::sendCtrlAck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of the #1610 the ACK sending code was moved to a dedicated function
CUDT::sendCtrlAck(..).The body of the function has no changes except for
breakstatements that are replaced byreturn.