[core] Reimplemented strerror to use static messages #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
maxsharabayko
requested changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1585
The procedure to prepare the error message using
std::stringhas been removed and replaced by a function that gets the pointer to a static array of characters that archive the message. The arrays with messages are generated from a comprehensive error message definitions using categories as defined originally in UDT.Note that generation of the major/minor enums is not supported. After a new error is introduced, it should be added to both definitions, the enum in
srt.hand in thegenerate-error-codes.tclscript, then the script should be run to regeneratestrerror_defs.cppfile. Also all enum values must be perfectly monotonic, as a jump over empty code or verification of the monotonicness of the values is not implemented in the generator script.