Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] Added CThread::joinable() unit test #1619

Merged
merged 2 commits into from
Oct 26, 2020
Merged

[tests] Added CThread::joinable() unit test #1619

merged 2 commits into from
Oct 26, 2020

Conversation

maxsharabayko
Copy link
Collaborator

@maxsharabayko maxsharabayko commented Oct 22, 2020 •
edited
Loading

The test confirms that CThread instance:

  1. is joinable even after the thread has finished its execution;
  2. is no longer joinable after join() was done.

Comes together with this PR:

  • Added missing override statement in srt-tunnel. Was generating a warning. Overrides Medium::CloseInternal().

@maxsharabayko maxsharabayko added Type: Enhancement Indicates new feature requests [tests] Area: Unit tests labels Oct 22, 2020
@maxsharabayko maxsharabayko added this to the v1.5.0 milestone Oct 22, 2020
@maxsharabayko maxsharabayko mentioned this pull request Oct 22, 2020
Closed
1 task
@mbakholdina mbakholdina modified the milestones: v1.5.0, v1.4.3 Oct 22, 2020
ethouris
ethouris reviewed Oct 23, 2020
View reviewed changes
apps/srt-tunnel.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Oct 23, 2020
View reviewed changes
test/test_sync.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Oct 23, 2020
View reviewed changes
test/test_sync.cpp Outdated Show resolved Hide resolved
ethouris
ethouris reviewed Oct 23, 2020
View reviewed changes
Copy link
Collaborator

@ethouris ethouris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider ^

@maxsharabayko
Copy link
Collaborator Author

Suggestions are applied.

@maxsharabayko
[apps] Added missing override,
584aacc 
removed redundant virtual
@maxsharabayko maxsharabayko merged commit 7658591 into Haivision:master Oct 26, 2020
@maxsharabayko maxsharabayko deleted the tests/cthread-join branch October 26, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethouris ethouris ethouris approved these changes

Assignees

@ethouris ethouris

Labels
[tests] Area: Unit tests Type: Enhancement Indicates new feature requests
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@maxsharabayko @ethouris @mbakholdina