[BUG] Fixed: SRTO_MINVERSION didn't cause rejection on too old version #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethouris
added
[core]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1577
Changes:
Fixed lacking check in the HSRSP parsing (caller side) that didn't check the incoming peer version against the set up minimum version. Also fixing the rejection code that was unnecessarily overridden when it was set elsewhere already.
Fixed option fields derivation when deriving options from listener to the accepted socket - minversion wasn't derived and therefore the
minversionoption was ineffective on a listenerAdded extra parsing possibility for the
minversionoption in the testing application so that it can also interpret a usual version string specification.