Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Set default stability timeout to 80ms #1565

Merged
merged 2 commits into from
Sep 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/APISocketOptions.md
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ The following table lists SRT socket options in alphabetical order. Option detai
| [`SRTO_EVENT`](#SRTO_EVENT) | | | `int32_t` | flags | | | R | S |
| [`SRTO_FC`](#SRTO_FC) | | pre | `int32_t` | pkts | 25600 | 32.. | RW | GSD |
| [`SRTO_GROUPCONNECT`](#SRTO_GROUPCONNECT) | 1.5.0 | pre | `int32_t` | | 0 | 0...1 | W | S |
| [`SRTO_GROUPSTABTIMEO`](#SRTO_GROUPSTABTIMEO) | | pre | `int32_t` | ms | 40 | 10-... | W | GSD+ |
| [`SRTO_GROUPSTABTIMEO`](#SRTO_GROUPSTABTIMEO) | | pre | `int32_t` | ms | 80 | 10-... | W | GSD+ |
| [`SRTO_GROUPTYPE`](#SRTO_GROUPTYPE) | | pre | `int32_t` | enum | | | R | S |
| [`SRTO_INPUTBW`](#SRTO_INPUTBW) | 1.0.5 | post | `int64_t` | B/s | 0 | 0.. | RW | GSD |
| [`SRTO_IPTOS`](#SRTO_IPTOS) | 1.0.5 | pre | `int32_t` | | (system) | 0..255 | RW | GSD |
Expand Down
2 changes: 1 addition & 1 deletion srtcore/core.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ CUDT::CUDT(CUDTSocket* parent): m_parent(parent)
m_iOPT_SndDropDelay = 0;
m_bOPT_StrictEncryption = true;
m_iOPT_PeerIdleTimeout = COMM_RESPONSE_TIMEOUT_MS;
m_uOPT_StabilityTimeout = 4*CUDT::COMM_SYN_INTERVAL_US;
m_uOPT_StabilityTimeout = CUDT::COMM_DEF_STABILITY_TIMEOUT_US;
m_OPT_GroupConnect = 0;
m_HSGroupType = SRT_GTYPE_UNDEFINED;
m_iOPT_RetransmitAlgo = 0;
Expand Down
1 change: 1 addition & 0 deletions srtcore/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ class CUDT
static const int SRT_TLPKTDROP_MINTHRESHOLD_MS = 1000;
static const uint64_t COMM_KEEPALIVE_PERIOD_US = 1*1000*1000;
static const int32_t COMM_SYN_INTERVAL_US = 10*1000;
static const uint32_t COMM_DEF_STABILITY_TIMEOUT_US = 80*1000;
static const int COMM_CLOSE_BROKEN_LISTENER_TIMEOUT_MS = 3000;
static const uint16_t MAX_WEIGHT = 32767;

Expand Down