[core] Added SRTO_ESTINPUTBW option to get estimated input bitrate #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsharabayko
added
Type: Enhancement
maxsharabayko
force-pushed
the
develop/pacing-mode-02
branch
from
6cafbfa to
8b0ca9c
Compare
maxsharabayko
commented
Sep 10, 2020
ethouris
reviewed
Sep 10, 2020
ethouris
reviewed
Sep 10, 2020
|
We probably need this option for the group as well 🤔 |
jeandube
approved these changes
Sep 10, 2020
|
Actually we haven't properly reviewed, how reading the option from the group really works. The problem here is that the estimation facility is in the socket, so a group would have to refer to a currently running member to get this value. |
to get estimated input bitrate Co-authored-by: duB <jdube@haivision.com>
maxsharabayko
force-pushed
the
develop/pacing-mode-02
branch
from
8b0ca9c to
0b5af89
Compare
|
Removed changes in documentation, as they are done in #1533 |
ethouris
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are extracted from #1383.
Added readonly
SRTO_ESTINPUTBWsocket option available viasrt_getsockopt(..)andsrt_getsockflag(..).